masaori335 commented on code in PR #12127:
URL: https://github.com/apache/trafficserver/pull/12127#discussion_r2013097452
##########
src/iocore/cache/StripeSM.cc:
##########
@@ -117,7 +117,7 @@ StripeSM::StripeSM(CacheDisk *disk, off_t blocks, off_t
dir_skip, int avg_obj_si
Stripe{disk, blocks, dir_skip, avg_obj_size, fragment_size},
fd{disk->fd},
disk{disk},
- _preserved_dirs{static_cast<int>(len)}
+ _preserved_dirs{len}
Review Comment:
Using `off_t` seems makes sense because this `Stripe::len` is `off_t`.
https://github.com/apache/trafficserver/blob/41523d163d4285aaccd0dbcdab3bd8aabc2a2a10/src/iocore/cache/Stripe.h#L76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
