cmcfarlen commented on code in PR #11951:
URL: https://github.com/apache/trafficserver/pull/11951#discussion_r1915451697
##########
src/proxy/http/remap/RemapConfig.cc:
##########
@@ -100,6 +97,14 @@ BUILD_TABLE_INFO::BUILD_TABLE_INFO()
BUILD_TABLE_INFO::~BUILD_TABLE_INFO()
{
this->reset();
+
+ // clean up any leftover named filter rules
+ auto *rp = rules_list;
+ while (rp != nullptr) {
+ auto *tmp = rp->next;
+ delete rp;
+ rp = tmp;
+ }
Review Comment:
They aren't actually shared, but copied into the actual mappings as they are
created. This code is very pointer-heavy and is over due for a general update
to C++ pass. I do plan on expanding this work soon, but wanted to get these
couple fixes that will need to be back ported. Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
