wForget commented on code in PR #2057:
URL: https://github.com/apache/datafusion-comet/pull/2057#discussion_r2325023860
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -711,8 +715,53 @@ object QueryPlanSerde extends Logging with CometExprShim {
binding,
(builder, binaryExpr) => builder.setNeqNullSafe(binaryExpr))
+ case GreaterThan(left, right) =>
+ createBinaryExpr(
+ expr,
+ left,
+ right,
+ inputs,
+ binding,
+ (builder, binaryExpr) => builder.setGt(binaryExpr))
+
+ case GreaterThanOrEqual(left, right) =>
+ createBinaryExpr(
+ expr,
+ left,
+ right,
+ inputs,
+ binding,
+ (builder, binaryExpr) => builder.setGtEq(binaryExpr))
+
+ case LessThan(left, right) =>
+ createBinaryExpr(
+ expr,
+ left,
+ right,
+ inputs,
+ binding,
+ (builder, binaryExpr) => builder.setLt(binaryExpr))
+
+ case LessThanOrEqual(left, right) =>
+ createBinaryExpr(
+ expr,
+ left,
+ right,
+ inputs,
+ binding,
+ (builder, binaryExpr) => builder.setLtEq(binaryExpr))
+
case Literal(value, dataType)
- if supportedDataType(dataType, allowComplex = value == null) =>
+ if supportedDataType(
+ dataType,
+ allowComplex = value == null ||
+ // Nested literal support for native reader
+ // can be tracked
https://github.com/apache/datafusion-comet/issues/1937
+ // now supports only Array of primitive
+ (Seq(CometConf.SCAN_NATIVE_ICEBERG_COMPAT,
CometConf.SCAN_NATIVE_DATAFUSION)
Review Comment:
Why is nested literal noly supported for native reader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
