adriangb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2210213790
##########
datafusion/datasource-parquet/src/row_filter.rs:
##########
@@ -106,6 +106,8 @@ pub(crate) struct DatafusionArrowPredicate {
rows_matched: metrics::Count,
/// how long was spent evaluating this predicate
time: metrics::Time,
+ /// used to perform type coercion while filtering rows
Review Comment:
> I think it is a bit unclear how the schema mapper and expression rewriter
work together
If you have an expression adapter you map the expression and the expression
is now evaluated against the physical file schema. So there is no longer a need
/ point of having a SchemaAdapter. It will still be there but it becomes a
no-op because it's adapting between identical schemas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
