andygrove commented on code in PR #1655:
URL: https://github.com/apache/datafusion-comet/pull/1655#discussion_r2051088550
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2920,7 +2936,8 @@ object QueryPlanSerde extends Logging with CometExprShim {
val canSort = sortOrder.head.dataType match {
case _: BooleanType => true
case _: ByteType | _: ShortType | _: IntegerType | _: LongType | _:
FloatType |
- _: DoubleType | _: TimestampType | _: TimestampType | _:
DecimalType | _: DateType =>
+ _: DoubleType | _: TimestampType | _: TimestampNTZType | _:
DecimalType |
Review Comment:
This is unrelated to the goal of the PR but I noticed we had TimestampType
twice and no TimestampNTZType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
