comphead commented on code in PR #15750:
URL: https://github.com/apache/datafusion/pull/15750#discussion_r2050828175
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -825,13 +831,21 @@ async fn fetch_schema(
store: &dyn ObjectStore,
file: &ObjectMeta,
metadata_size_hint: Option<usize>,
+ coerce_int96: Option<TimeUnit>,
) -> Result<Schema> {
let metadata = fetch_parquet_metadata(store, file,
metadata_size_hint).await?;
let file_metadata = metadata.file_metadata();
let schema = parquet_to_arrow_schema(
file_metadata.schema_descr(),
file_metadata.key_value_metadata(),
)?;
+ let schema = match coerce_int96 {
Review Comment:
a nit: it might be rewritten more concise ?
```
let schema = coerce_int96
.and_then(|time_unit|
coerce_int96_to_resolution(file_metadata.schema_descr(), &schema,
&time_unit).ok())
.unwrap_or(schema);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
