iffyio commented on code in PR #1540:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1540#discussion_r1855103049


##########
src/parser/mod.rs:
##########
@@ -8349,6 +8349,13 @@ impl<'a> Parser<'a> {
     pub fn parse_object_name(&mut self, in_table_clause: bool) -> 
Result<ObjectName, ParserError> {
         let mut idents = vec![];
         loop {
+            if self.dialect.supports_object_name_double_dot_notation()
+                && idents.len() == 1
+                && self.peek_token() == Token::Period
+            {
+                self.next_token();
+                idents.push(Ident::new(""));

Review Comment:
   Ah I realised this is empty due to the display adding the dot on its behalf. 
Could we add a comment what this line does? since its not obvious otherwise



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to