alamb commented on code in PR #13349:
URL: https://github.com/apache/datafusion/pull/13349#discussion_r1840332546
##########
test-utils/src/array_gen/primitive.rs:
##########
@@ -17,8 +17,9 @@
use arrow::array::{ArrayRef, ArrowPrimitiveType, PrimitiveArray, UInt32Array};
use arrow::datatypes::DataType;
-use rand::rngs::StdRng;
-use rand::Rng;
+use chrono_tz::{Tz, TZ_VARIANTS};
Review Comment:
TIL: https://docs.rs/chrono-tz/latest/chrono_tz/static.TZ_VARIANTS.html 👍
##########
datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs:
##########
@@ -172,6 +172,8 @@ fn baseline_config() -> DatasetGeneratorConfig {
ColumnDescr::new("time32_ms", DataType::Time32(TimeUnit::Millisecond)),
ColumnDescr::new("time64_us", DataType::Time64(TimeUnit::Microsecond)),
ColumnDescr::new("time64_ns", DataType::Time64(TimeUnit::Nanosecond)),
+ // `None` is passed in here however when generating the array, it will
generate
Review Comment:
💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
