findepi commented on code in PR #13350:
URL: https://github.com/apache/datafusion/pull/13350#discussion_r1837086637
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -334,7 +334,10 @@ impl From<&DataType> for TypeCategory {
// therefore, it is categorized as a unknown type
if matches!(
data_type,
- DataType::Utf8 | DataType::LargeUtf8 | DataType::Null
+ DataType::Utf8
+ | DataType::LargeUtf8
+ | DataType::Utf8View
+ | DataType::Null
Review Comment:
Adding Utf8View LGTM
but the comment above "String literal is possible to cast to many other
types like numeric or datetime," is worrisome. I don't think it's true.
Would it make sense to update that comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
