mbutrovich commented on code in PR #26593:
URL: https://github.com/apache/datafusion/pull/26593#discussion_r4468067343
##########
datafusion/common/src/partitioning.rs:
##########
@@ -68,8 +65,8 @@ impl Display for SplitPoint {
}
}
-/// Validates that split points match the ordering width and are strictly
-/// ordered according to the provided sort options.
+/// Validates that split points match the ordering width and are non-decreasing
+/// according to the provided sort options. Equal split points imply empty
partitions.
Review Comment:
`validate_range_split_points` is public and shipped in 55.0.0 as a strict
check
([docs](https://github.com/apache/datafusion/blob/d5552342012888b7d1a3ab88d92e3d292fc0cde0/datafusion/common/src/partitioning.rs#L71-L72)).
A caller that relied on it to reject equal split points now gets `Ok(())`
instead. Could we add an upgrade guide entry for this next to the range
partitioning section in
[`56.0.0.md`](https://github.com/apache/datafusion/blob/32bd81fb226ccf1ae5df67ff340d77baa3e73668/docs/source/library-user-guide/upgrading/56.0.0.md?plain=1#L263-L280),
or in a 57.0.0 guide if this misses `branch-56`? That section already covers
the `FFI_RangePartitioning` layout and the generated
`PhysicalRangePartitioning` fields for the samples change, so the same entry
could cover the two new bounds fields in each, and the fact that equality now
includes bounds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
