andygrove opened a new pull request, #2747:
URL: https://github.com/apache/datafusion-ballista/pull/2747
# Which issue does this PR close?
No issue filed; the bug is described below. Related: #2745, which proposes
compiling the event-log writer without the REST API.
# Rationale for this change
`ballista-scheduler` doesn't compile with `--no-default-features --features
rest-api`:
```
error[E0433]: cannot find module or crate `tracing` in this scope
error: could not compile `ballista-scheduler` (lib) due to 18 previous errors
```
The REST handlers (`src/api/handlers.rs`) and the event-log history
(`src/history/mod.rs`) log through `tracing`, which is an optional dependency.
Only the default `build-binary` feature enabled it, so the default build hid
the problem. An embedder that turns off the default features and asks for
`rest-api`, for example to get the event-log writer, can't build. Apache
DataFusion Comet hit this in apache/datafusion-comet#7420 and works around it
by enabling `tracing` itself.
# What changes are included in this PR?
- The `rest-api` feature enables `tracing`.
- The `--no-default-features` CI job also checks the scheduler with only
`rest-api` enabled.
# Are there any user-facing changes?
No. Builds that already compiled are unchanged. `ballista-scheduler` with
`--no-default-features --features rest-api` now compiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
