jayzhan211 commented on code in PR #25853:
URL: https://github.com/apache/datafusion/pull/25853#discussion_r4435947546
##########
datafusion/sqllogictest/test_files/aggregate_memory_spill.slt:
##########
@@ -239,6 +239,146 @@ FROM (
08)--------------AggregateExec: mode=Partial, gby=[v@0 * 7 % 100000 as t.v *
Int64(7) % Int64(100000)], aggr=[sum(t.v)],
metrics=[<slt:ignore>early_emit_count=<slt:ignore>]
<slt:ignore>
+# --- Case H: a few groups with large state ---
Review Comment:
Optional: every Case H query uses `array_agg`, so only the list-of-views
path is covered end to end. A `string_agg` case exercises top-level bytes
state; it fails on main and passes with this PR at `-m 128M`:
```sql
SET datafusion.execution.target_partitions = 2;
SELECT count(*), sum(n) FROM (
SELECT value % 16 AS k, length(string_agg(concat(CAST(value AS VARCHAR),
repeat('x', 100)), ',')) AS n
FROM generate_series(1, 3000000)
GROUP BY value % 16);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
