LucaCappelletti94 opened a new pull request, #2792: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2792
The `coverage` check is a required status check on `main`. For example, #2755 is approved and green on every other check, but four lines of a `Spanned` match arm in `src/ast/spans.rs` have no test, and I have no intention to add because that is code that will likely need a refactoring and its current implementations are all of the "needs improvement" kind. This removes `coverage` from the required checks in `.asf.yaml`. @alamb you were right and I was being a bit too hopeful, lets keep this as just a mark of shame for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
