sam-1112 commented on PR #7198: URL: https://github.com/apache/datafusion-comet/pull/7198#issuecomment-6555024545
Thanks for the detailed review and for investigating the reader compatibility, @andygrove. I reproduced the schema behavior with our pinned dependencies: parquet-rs emits the UUID annotation when its writer schema carries `arrow.uuid`, but tagging the incoming batches does not affect iceberg-rust’s independently constructed writer schema. The feature is already enabled, so this confirms your follow-up. I’ve kept the pin unchanged and addressed the requested updates: - Linked apache/iceberg-rust#2930 in the divergence note, with instructions to verify top-level and nested annotations, update the assertions, and remove the note when upgrading. - Added the upgrade reminder beside `leaf.getLogicalTypeAnnotation == null`. - Updated both stale function references to `UuidAlignment::convert`. - Added `iceberg_uuid.rs` and the UUID action/detection test coverage to the contributor guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
