github-actions[bot] commented on PR #26979: URL: https://github.com/apache/datafusion/pull/26979#issuecomment-6552779876
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning 5db4b233efde58f6b34299fb15b756e7bdef2698 Building datafusion v55.1.0 (current) Built [ 51.776s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.031s] (current) Building datafusion v55.1.0 (baseline) Built [ 16.223s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.715s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 70.508s] datafusion Building datafusion-ffi v55.1.0 (current) Built [ 26.572s] (current) Parsing datafusion-ffi v55.1.0 (current) Parsed [ 0.063s] (current) Building datafusion-ffi v55.1.0 (baseline) Built [ 18.424s] (baseline) Parsing datafusion-ffi v55.1.0 (baseline) Parsed [ 0.063s] (baseline) Checking datafusion-ffi v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.304s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 46.716s] datafusion-ffi Building datafusion-physical-optimizer v55.1.0 (current) Built [ 17.339s] (current) Parsing datafusion-physical-optimizer v55.1.0 (current) Parsed [ 0.019s] (current) Building datafusion-physical-optimizer v55.1.0 (baseline) Built [ 13.705s] (baseline) Parsing datafusion-physical-optimizer v55.1.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-physical-optimizer v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.125s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 31.978s] datafusion-physical-optimizer Building datafusion-session v55.1.0 (current) Built [ 12.817s] (current) Parsing datafusion-session v55.1.0 (current) Parsed [ 0.007s] (current) Building datafusion-session v55.1.0 (baseline) Built [ 12.491s] (baseline) Parsing datafusion-session v55.1.0 (baseline) Parsed [ 0.007s] (baseline) Checking datafusion-session v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.233s] 229 checks: 228 pass, 1 fail, 0 warn, 31 skip --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/trait_method_added.ron Failed in: trait method datafusion_session::physical_optimizer::PhysicalOptimizerRule::phase in file /home/runner/work/datafusion/datafusion/datafusion/session/src/physical_optimizer.rs:192 trait method datafusion_session::PhysicalOptimizerRule::phase in file /home/runner/work/datafusion/datafusion/datafusion/session/src/physical_optimizer.rs:192 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 26.465s] datafusion-session ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
