2010YOUY01 commented on code in PR #26983:
URL: https://github.com/apache/datafusion/pull/26983#discussion_r4434260207
##########
datafusion/core/tests/fuzz_cases/sort_query_fuzz.rs:
##########
@@ -593,11 +593,9 @@ impl SortFuzzerTestGenerator {
let ctx =
self.generate_random_config(config_seed, false,
Some(threshold))?;
let actual = ctx.sql(&query_str).await?.collect().await?;
- assert_eq!(
- results,
- concat_batches(&schema, &actual)?,
- "sort_in_place_threshold_bytes={threshold}"
- );
+ check_equality_of_batches(&results,
&actual).unwrap_or_else(|err| {
Review Comment:
The only core change is this line, all other diffs are propagated changes.
The essence is, there might be two batches, that are logically the same, but
physically different. So comparing formatted string works for assertion, while
direct `eq` on `RecordBatch` can't do comparison for logical equivalence.
The actual failing case is in one dictionary encoding array, I've let Codex
verified it's the above case, and it can be reproduced by regression test added
in this PR.
This change was introduced 2 days ago in
- https://github.com/apache/datafusion/pull/26242
I guess it's for clean up, this PR reverts it to the original version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
