sdf-jkl commented on code in PR #26854:
URL: https://github.com/apache/datafusion/pull/26854#discussion_r4428395579
##########
datafusion/core/tests/parquet/schema.rs:
##########
@@ -176,6 +176,53 @@ async fn schema_merge_can_preserve_metadata() {
assert_metadata(&actual, &expected_metadata);
}
+/// The extension type is part of the type of a field, so it is kept when the
other
+/// field metadata is cleared.
+#[tokio::test]
+async fn schema_merge_keeps_extension_types_by_default() {
Review Comment:
I'm a proponent of using SLTs vs unit tests 🤓 (someone I know feels the
same way @alamb)
- we can replace false with true here
https://github.com/apache/datafusion/blob/611311cd7ef50b40dd33f88ec527e2913de8e3d1/datafusion/sqllogictest/test_files/cast_extension_type_metadata.slt#L98
- change the comment here to explain that ext type metadata is kept
https://github.com/apache/datafusion/blob/611311cd7ef50b40dd33f88ec527e2913de8e3d1/datafusion/sqllogictest/test_files/information_schema.slt#L428
- drop the new unit tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
