jinjin1919 commented on issue #6984: URL: https://github.com/apache/datafusion-comet/issues/6984#issuecomment-6504660476
Hi @andygrove, I'd like to work on the Map arm of this issue: the four null-aware loops for (Utf8, Int32), (Int32, Utf8), (Utf8, Utf8) and (Int32, Int32) in `hash_funcs/utils.rs` (L1110-L1219 at 7d8d9b1544b7). I haven't started on the code yet, so I wanted to check first that this would be welcome. @med9110, I saw that you're taking the string/binary list hashing and leaving the map-entry refactor for a separate PR. If you're still on that, I'll keep the map refactor in its own PR so we don't overlap. If you'd rather do both parts yourself, just say so and I'll step back. First step: I'll read the Map arm against the existing murmur3/xxhash64 tests and sketch the `hash_map_entries!` helper the issue proposes. I'll report back here by Monday (Nov 2) with what I find. If I can't keep working on this, I'll say so here so someone else can pick it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
