rgbuilds commented on PR #26452: URL: https://github.com/apache/datafusion/pull/26452#issuecomment-6490561958
> Thanks @rgbuilds, LGTM. I leave some additional suggestions below. I also don't think the Rust tests are necessary since the slt ones appear to cover everything, but it's not critical if they stay. Thanks @nuno-faria. I kept the Rust coverage because it complements the SLT: the unit test covers `CAST`/`TRY_CAST` across all `Time32`/`Time64` units and timezone variants, while the Parquet test verifies the pruning metrics directly. The SLT provides the end-to-end result comparison. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
