andygrove commented on PR #7096: URL: https://github.com/apache/datafusion-comet/pull/7096#issuecomment-6360340063
Thanks @comphead. Both review-body items are in 6303b8e39: - `ORDERED_FINAL_AGGREGATE` in `spill_replay.rs` is the one copy of the prefix, used by `is_final_aggregate` and the fair pool. The module doc's list of DataFusion names to re-check on an upgrade now includes `OrderedFinalAggregateStream` registering as spillable, with a note to drop the fair pool's exception once apache/datafusion#17334 is fixed. - `spillable(name, pool)` lives once in `memory_pools/testing.rs`, and the `fair_pool.rs`, `spill_replay.rs`, `mod.rs` and `iceberg_write.rs` tests use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
