1fanwang commented on code in PR #25767:
URL: https://github.com/apache/datafusion/pull/25767#discussion_r4356449114
##########
datafusion/sql/src/set_expr.rs:
##########
@@ -178,4 +180,21 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
}
}
}
+
+ fn functions_for_set_operation(
+ &self,
+ ) -> Result<(
+ Arc<datafusion_expr::AggregateUDF>,
+ Arc<datafusion_expr::ScalarUDF>,
+ )> {
+ let (Some(count), Some(range)) = (
+ self.context_provider.get_aggregate_meta("count"),
+ self.context_provider.get_function_meta("range"),
Review Comment:
Done in
https://github.com/apache/datafusion/commit/9025f82e6ca17896f7917baa2a81bc2261aabb36.
SQL, DataFrame and Substrait planning now use built-in functions, with runtime
regressions for shadowed registry names.
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -1963,7 +1963,16 @@ impl DataFrame {
pub fn intersect(self, dataframe: DataFrame) -> Result<DataFrame> {
let left_plan = self.plan;
let right_plan = dataframe.plan;
- let plan = LogicalPlanBuilder::intersect(left_plan, right_plan, true)?;
+ let (Some(count), Some(range)) = (
+ self.session_state.aggregate_functions().get("count"),
+ self.session_state.scalar_functions().get("range"),
Review Comment:
Done in
https://github.com/apache/datafusion/commit/9025f82e6ca17896f7917baa2a81bc2261aabb36.
The upgrade note documents the feature requirement, and regression coverage
exercises planning without nested expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
