sam-1112 commented on PR #7095: URL: https://github.com/apache/datafusion-comet/pull/7095#issuecomment-6356933110
@comphead Thanks! I addressed all three points: - Range shuffle now converts and collects current failure reasons within a dedicated scope through a serde helper, including reasons on child expressions. - I found no independent production entry into `exprToProtoInternal`, so I removed its scope wrapper and documented the caller’s responsibility. - The journal and its accessors now accept only `Expression`. `withFallbackReasons` matches on the node type, preserving sticky operator tags and avoiding the redundant union. The new range-shuffle regression fails with the old tag reader: it includes the stale sort-order reason and misses the current child failure reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
