pepijnve commented on PR #25887:
URL: https://github.com/apache/datafusion/pull/25887#issuecomment-6350881243

   > yes I think we should revert the CLI behavior back
   
   Will do
   
   > EXPLAIN SHOW TABLES stopped working
   
   I'll look into that. I'll start by adding SLTs to cover the behaviour.
   
   > There are a bunch of new NULL views in information schema
   
   Would you prefer to split that part off? The information_schema schema 
itself is included in the information_schema views since they do exist and can 
describe themselves. The view definition is a bit tricky to actually write 
though since these are implemented as virtual tables. We can fill in a pseudo 
definition if that's preferred over the null value, but it won't be SQL you can 
actually execute. We would have to describe what the underlying definition 
schema is then.
   
   Example from postgresql
   
   ```
    table_catalog |    table_schema    |              table_name               
|                                                                               
                                                                                
                                                                                
                                                               view_definition
   
---------------+--------------------+---------------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    pepijn        | information_schema | schemata                              
|  SELECT (current_database())::information_schema.sql_identifier AS 
catalog_name,                                                                   
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                       +
                  |                    |                                       
|     (n.nspname)::information_schema.sql_identifier AS schema_name,            
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                            +
                  |                    |                                       
|     (u.rolname)::information_schema.sql_identifier AS schema_owner,           
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                            +
                  |                    |                                       
|     (NULL::name)::information_schema.sql_identifier AS 
default_character_set_catalog,                                                  
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
   +
                  |                    |                                       
|     (NULL::name)::information_schema.sql_identifier AS 
default_character_set_schema,                                                   
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
   +
                  |                    |                                       
|     (NULL::name)::information_schema.sql_identifier AS 
default_character_set_name,                                                     
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
   +
                  |                    |                                       
|     (NULL::character varying)::information_schema.character_data AS sql_path  
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                            +
                  |                    |                                       
|    FROM pg_namespace n,                                                       
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                            +
                  |                    |                                       
|     pg_authid u                                                               
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                            +
                  |                    |                                       
|   WHERE ((n.nspowner = u.oid) AND (pg_has_role(n.nspowner, 'USAGE'::text) OR 
has_schema_privilege(n.oid, 'CREATE, USAGE'::text)));
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to