Omega359 commented on code in PR #26452:
URL: https://github.com/apache/datafusion/pull/26452#discussion_r4342479584
##########
datafusion/pruning/src/pruning_predicate.rs:
##########
@@ -4984,6 +4994,46 @@ mod tests {
Ok(())
}
+ #[test]
+ fn row_group_predicate_cast_timestamp_to_time() {
Review Comment:
```suggestion
fn row_group_predicate_cast_timestamp_to_time() {
// A timezone shifts where the day boundary falls but does not remove
// it, so a timezone-aware timestamp is just as unsafe to prune on.
for timestamp_type in [
DataType::Timestamp(TimeUnit::Second, None),
DataType::Timestamp(TimeUnit::Second, Some("+05:00".into())),
DataType::Timestamp(TimeUnit::Nanosecond, Some("UTC".into())),
] {
assert_timestamp_to_time_cast_is_not_prunable(timestamp_type);
}
}
/// Asserts that no comparison of `CAST`/`TRY_CAST` from
`timestamp_type` to
/// a time-of-day produces a pruning expression.
fn assert_timestamp_to_time_cast_is_not_prunable(timestamp_type:
DataType) {
```
I had claude update the test to handle timestamp with tz as I wanted to be
sure that this fix covered that case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
