pelovett commented on PR #2467: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2467#issuecomment-6326305138
Hey @LucaCappelletti94 , sorry for the delay in responding to your comments after requesting them. I've updated the code with your suggestions and added a fix for check constraints without parentheses. My solution adds a field to the constraint structs tracking if they were created with parentheses. This would be a breaking change for these structs. The other option I could think of was storing the parenthesis state by wrapping the expressions in `Expr::Nested` but this could break code that creates structs manually rather than with the parser. Not sure the best option here but would appreciate your opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
