sunchao commented on PR #6035: URL: https://github.com/apache/datafusion-comet/pull/6035#issuecomment-6323894106
@andygrove @viirya, addressed the latest review in `eea8a6b00`. The [compatibility guide](https://github.com/apache/datafusion-comet/blob/eea8a6b0004e6a4c2a076216629246000a5b72ca/docs/source/user-guide/latest/compatibility/index.md#ansi-errors-from-rows-skipped-by-limit) now explains the ANSI error difference and includes Andy's throwing-filter example. Filed #7147 under the broader #6006 with the reproduced filter and non-collect LocalLimit/GlobalLimit plan cases, their physical plans, and the remaining ordered-input `TakeOrderedAndProject` investigation. These are preexisting gaps left for separate fixes. The issue also distinguishes discarded rows that Spark legitimately evaluates, including blocking operations and `CollectTail`. The rule's scaladoc links the issue. Added the requested synthetic-node config/serde and fallback-tag explanation, combined the two early exits into one conditional, and retained the cross-batch and per-partition tests unchanged. I replied to all four new inline threads and resolved those plus the three older addressed threads. Validation on this commit: native debug build, all 116 focused Spark 4.0 tests, Spotless, Scalastyle, repository-wide Markdown Prettier, and `git diff --check` passed. All nine Spark 4.1 SQL jobs passed on the previous head `1dc896732` ([run](https://github.com/apache/datafusion-comet/actions/runs/39365819149)); the `run-spark-4.1-tests` label remains enabled, and [CI for this new commit](https://github.com/apache/datafusion-comet/actions/runs/39655951685) is queued. Could you re-review the update? The earlier changes-requested review is still active, so it needs an updated review verdict before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
