parthchandra commented on code in PR #6784:
URL: https://github.com/apache/datafusion-comet/pull/6784#discussion_r4340140198
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -457,6 +458,9 @@ case class CometExecRule(session: SparkSession,
queryStagePrep: Boolean = false)
case scan: CometBatchScanExec if scan.wrapped.scan.isInstanceOf[CSVScan]
=>
convertToComet(scan, CometCsvNativeScanExec).getOrElse(scan.wrapped)
+ case scan: CometBatchScanExec if
scan.wrapped.scan.isInstanceOf[TextScan] =>
+ convertToComet(scan, CometTextNativeScanExec).getOrElse(scan)
Review Comment:
Fixed. A declined Text conversion now returns scan.wrapped, like the CSV
branch, so the query falls back to Spark's row-producing scan instead of
failing with the ClassCastException. Added Text tests for the two ABFS layouts
(different accounts, different containers). (CometExecRule.scala:462;
AbfsScanFallbackSuite.scala)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
