adriangb commented on PR #26356: URL: https://github.com/apache/datafusion/pull/26356#issuecomment-6316371385
Agreed, it looks redundat: `Aggregate::try_new folds` any group list that contains a grouping set into a single `GroupingSet` (via `enumerate_grouping_sets`), so the first two conditions always return first. I removed it in 99902be5a6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
