yunchipang opened a new pull request, #7141:
URL: https://github.com/apache/datafusion-comet/pull/7141
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #6803.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Several tests in `CometIcebergWriteDetectionSuite` inspect
`IcebergWriteExec`, which only exists when the Iceberg write is split into
Spark's write node plus Comet's commit. They get their input from `VALUES` or
`createDataFrame`, which plan as a `LocalTableScan`. With
`spark.comet.exec.localTableScan.enabled=true`, as proposed in #6780, Comet
runs that input and the whole write becomes native (`CometIcebergWrite` over
`CometLocalTableScan`). No `IcebergWriteExec` is left, and 5 tests fail.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Test-only. `captureWriteExec` and `planInsertWriteExec` now set
`spark.comet.exec.localTableScan.enabled=false`, so tests that need an
`IcebergWriteExec` get the split plan whatever the default is. Tests that check
the fully native write are unchanged.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
`CometIcebergWriteDetectionSuite` passes locally (80/80) both with the
current default and with the `localTableScan` default flipped to `true` as in
#6780.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
