terbed commented on code in PR #65:
URL: https://github.com/apache/datafusion-iceberg/pull/65#discussion_r4328851556


##########
Cargo.toml:
##########
@@ -37,8 +37,8 @@ datafusion = "55.0.0"
 datafusion-cli = "55.0.0"
 iceberg-datafusion = { path = "crates/datafusion" }
 datafusion-sqllogictest = "55.0.0"
-iceberg = { git = "https://github.com/apache/iceberg-rust";, rev = 
"8cb2adeddb4f8da1ca7bd86ca303337f011c12e2" }
-iceberg-catalog-rest = { git = "https://github.com/apache/iceberg-rust";, rev = 
"8cb2adeddb4f8da1ca7bd86ca303337f011c12e2" }
+iceberg = { git = "https://github.com/apache/iceberg-rust";, rev = 
"3c952e1719a4902334e44b648698999cf3a4214d" }
+iceberg-catalog-rest = { git = "https://github.com/apache/iceberg-rust";, rev = 
"3c952e1719a4902334e44b648698999cf3a4214d" }

Review Comment:
   Sure we can separate that! The reason for the bump is that there is a 
related fix there ensuring correct page indexing in some cases (and decimal 
pruning optimizations). But current icebereg-rust version pinned by datafusion 
is sufficient for this PR and we can remove this bump.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to