0xamlab commented on PR #26529: URL: https://github.com/apache/datafusion/pull/26529#issuecomment-6291837997
Verified locally on the PR branch: `cargo test -p datafusion-physical-expr --lib` passes 1710 tests, and `cargo test -p datafusion-sqllogictest --test sqllogictests -- struct.slt` completes all 4 matched files. I also applied the new `struct.slt` cases to `main`; they fail there with `Unsupported TRY_CAST from Struct...` (5 errors). The fix is the shared `can_plan_cast` helper at `datafusion/physical-expr/src/expressions/cast.rs:154`, called from `try_cast.rs:309` and `:353`, which routes struct casts through the same name-based compatibility check that `CAST` already uses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
