PreetiToppo commented on issue #26497: URL: https://github.com/apache/datafusion/issues/26497#issuecomment-6287332898
While @CuteChuanChuan is tackling the accumulators for #26497, I would love to implement the centralized architectural fix suggested in the context. I'll add a planning-time check inside `AggregateExprBuilder::build` that automatically returns a `not_impl_err!` if `is_distinct` is true and the function indicates `DistinctHandling::Unsupported`. I will open a PR for this refactor! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
