yunchipang opened a new pull request, #7122:
URL: https://github.com/apache/datafusion-comet/pull/7122
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #6782.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
If an Iceberg equality delete is keyed on a nested field such as `s.k`,
every native scan of the table fails with `field not found`. iceberg-rust only
looks up top-level columns. The upstream fix is apache/iceberg-rust#3453. Until
Comet picks it up, this case should fall back to Spark.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- `CometScanRule`: fall back when an equality delete's key is not a
top-level column in any of the table's schemas.
- `CometEqualityDeletes`: a test helper option to key a delete on a nested
field.
- `iceberg.md`: list this case as a fallback instead of a known failure.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
A new test in `CometIcebergNativeSuite` keys a delete on `s.k`. It checks
that the result matches Spark and that the scan falls back. It fails without
the fix. The existing equality delete tests still pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
