andygrove commented on PR #6180: URL: https://github.com/apache/datafusion-comet/pull/6180#issuecomment-6278527027
Thanks for dropping the config. The decimal-promotion finding from sunchao's review is still open at `dd8ce9f789`. `exprToProto` runs `DecimalPrecision.promote` before `CometAtLeastNNonNulls.convert`, so the skippable children are `Cast(CheckOverflow(...))`. `sharedSubexpressions.common` holds the unpromoted `Cast`. `canSkipEvaluation` never sees a match for those children, so the fallback is skipped and Comet returns `true` where Spark raises `DIVIDE_BY_ZERO`. Could the fix go in `canSkipEvaluation` so the `canShortCircuitNulls` callers are covered too? A regression test with a repeated decimal `Cast(Divide(a, b), IntegerType)` under ANSI would pin it. The current test uses a string cast, which `promote` doesn't change, so it can't catch this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
