LucaCappelletti94 commented on code in PR #2680:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2680#discussion_r4318284581
##########
src/parser/mod.rs:
##########
@@ -4481,6 +4481,19 @@ impl<'a> Parser<'a> {
let array_expr = self.parse_expr()?;
self.expect_token(&Token::RParen)?;
InTarget::Unnest(Box::new(array_expr))
+ } else if !global
+ && self.dialect.supports_in_table_expression()
+ && matches!(self.peek_token_ref().token, Token::Word(_))
Review Comment:
`is_table_factor` with the shared list would still accept this one, since
`FROM` is not in `RESERVED_FOR_TABLE_FACTOR`. I ran every keyword of the crate
through SQLite 3.51.1 as `SELECT 1 IN <kw>`, and SQLite refuses 57 of them
there, so now `SQLiteDialect` overrides `is_table_factor` with those, so
`SELECT 1 IN FROM t` fails again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
