kazuyukitanimura commented on PR #7025: URL: https://github.com/apache/datafusion-comet/pull/7025#issuecomment-6273596426
@andygrove Thanks for running it on 3.5. You were right: the inner CASE used an element-typed NULL, so it returned Int32 where the outer returned lists. Both ELSE branches now use ArrayType(elementType, containsNull = true). A Rust test in case_when.rs builds that plan and fails with the element-typed NULL. I also moved the error queries to expect_error_class, added non-ANSI queries (your repro included), and reverted the CI commit, which belongs with #6947. On the non-ANSI cost: each row evaluates the item once, so the extra work is the item over NULL-array rows, as in Spark. I kept the gate to literals and columns, because a broader "cannot throw" check needs a per-version allow-list. I'd do that as a follow-up. On #5867, which should land first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
