U0001F3A2 commented on PR #23676: URL: https://github.com/apache/datafusion/pull/23676#issuecomment-6264397841
@Jefffrey pushed your signature approach in 37d3fdb (after merging main). It fixes the types and the precision on its own, so the widest-float `return_type` and the runtime cast are gone. `invoke_with_args` and `return_type` now match main. This corrects my last comment. The simplification change isn't needed anymore, because #25138 removed the `log(a, 1)` / `log(a, a)` rewrites, so it dropped out in the merge. One small addition was still needed. The `Native(...)` coercions turn an untyped NULL into a typed one, so `log(NULL, c2)` became `log(Float64(NULL), c2)` and lost its plan-time NULL fold (the existing `EXPLAIN` case in `math.slt`). `simplify` now also folds typed NULL literals. Other expectation changes: - `order.slt`: two plans now show `CAST(c11 AS Float64)` (c11 is Float32, c12 is Float64). The sorts are still kept. - `log(2.5::float, NULL)` stays Float64, same as main. My previous revision had changed it to Float32. I also added an upgrade guide entry for the result type change. The full sqllogictest suite, `datafusion-functions` lib tests and clippy pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
