andygrove commented on PR #5496: URL: https://github.com/apache/datafusion-comet/pull/5496#issuecomment-6238017030
Following up on my earlier comment, I checked each ask against the current branch and all of them are in: - Dictionary coverage: `DirectColumnarToRowConverterSuite` now builds dictionary-encoded vectors directly and runs compact and wide decimals through them, byte-compared with `UnsafeProjection`. - Early-exit and memory trade-offs: the tuning guide now covers both the `LIMIT` cost of the fixed-width path and the per-task `batchBuffer`, with the 6.7 MB example. - `changePrecision`: `compactDecimalValue` and `writeWideDecimal` both document why that check is skipped. I merged current `main` into the branch (only conflict was `CometUnsafeProjection` from #6858 in `convertBatches`) and re-ran both suites against a debug native build: 11 passed. Nothing else outstanding from me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
