LucaCappelletti94 opened a new pull request, #2655:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2655

   `CREATE TABLE t (a INT) ENGINE = "MergeTree"` lost its quotes on display and 
was printed back as `ENGINE = MergeTree`, and the same happened to `` ENGINE = 
`InnoDB` ``, because the engine name was rebuilt with `Ident::new` from the 
bare word value.
   
   Both engines accept a quoted engine name: ClickHouse quotes identifiers with 
double quotes or backticks 
(https://clickhouse.com/docs/reference/syntax#identifiers), and MySQL documents 
that the engine name can be unquoted or quoted 
(https://dev.mysql.com/doc/refman/8.4/en/create-table.html#create-table-options).
   
   The engine name is now built with `Word::into_ident`, which keeps the 
original quote style and the token span.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to