ahlag commented on issue #26298: URL: https://github.com/apache/datafusion/issues/26298#issuecomment-6233046595
In #26443, I moved the `Join` arm into `join_to_sql` as a pure refactor, placing it next to the existing `asof_join_to_sql`. For the remaining work, I propose proceeding one PR at a time in this order: 1. `SubqueryAlias` 2. The five small clause branches (`Filter`, `Sort`, `Limit`, `Distinct`, and `Aggregate`) 3. `TableScan` and the unnest branches 4. `Projection` (moving it as a whole first, then splitting it) 5. `Union` after #24455, since that open PR rewrites the `Union` branch 6. The `(query, select, relation)` context struct last, if it's still worth it by then Before proceeding, I'd appreciate feedback on a few points: - Should the extracted methods follow the existing `*_to_sql` naming convention or the `select_join`-style naming suggested in the issue? - Should every extracted method use `#[inline(never)]`, like `asof_join_to_sql`? - Would it be better to group the five small clause branches into one PR or submit them separately? Happy to adjust the order based on feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
