2010YOUY01 commented on PR #26228: URL: https://github.com/apache/datafusion/pull/26228#issuecomment-6228367099
> To be clear, this PR doesn't make that promise: `maintains_input_order` still reports false for the build side, so a spilling hash join could emit rows in any order later. This PR is already making a promise with UTs asserting output order. If you only need it at operator level in comet, perhaps we can do a alternative constructor ``` HashJoinExec::new_with_ordered_build() ``` Instead of doing https://github.com/apache/datafusion/issues/26235, and make it into a plan-level optimization guarantee. @jayzhan211 suggested use config to use config to set the ordering promise, I think this might cause some extra challenge for planning/optimization. Thank you for the invetigations 🙏🏼 @dwsmith1983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
