parthchandra commented on code in PR #7043:
URL: https://github.com/apache/datafusion-comet/pull/7043#discussion_r4300170283
##########
spark/src/test/scala/org/apache/comet/CometIcebergTestBase.scala:
##########
@@ -167,6 +167,37 @@ trait CometIcebergTestBase { this: CometTestBase =>
.getMethod("ofLength", classOf[Int])
.invoke(null, Integer.valueOf(length))
+ /**
+ * Whether the Iceberg runtime on the classpath can report an output
ordering. Only the newer
+ * Apple builds can (1.5.0.37-apple+ and 1.9.1.6-apple+); upstream releases
and older Apple
+ * builds cannot, so ordering-dependent tests must gate on this capability
rather than on a
+ * version number. We probe for SortOrderAnalyzer, which ships in exactly
the builds whose
+ * SparkPartitioningAwareScan reports an ordering. Returns false if the
class is missing so
+ * those tests skip rather than fail.
+ */
+ protected def icebergReportsOrdering: Boolean =
Review Comment:
yes indeed. changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
