github-actions[bot] commented on PR #26056: URL: https://github.com/apache/datafusion/pull/26056#issuecomment-6226241434
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-expr v55.1.0 (current) Built [ 38.607s] (current) Parsing datafusion-physical-expr v55.1.0 (current) Parsed [ 0.048s] (current) Building datafusion-physical-expr v55.1.0 (baseline) Built [ 27.578s] (baseline) Parsing datafusion-physical-expr v55.1.0 (baseline) Parsed [ 0.048s] (baseline) Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.402s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: CastExpr::with_new_expr_and_target_field, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-expr/src/expressions/cast.rs:292 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 67.868s] datafusion-physical-expr Building datafusion-physical-plan v55.1.0 (current) Built [ 37.247s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.179s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 36.863s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.186s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.643s] 223 checks: 215 pass, 8 fail, 0 warn, 31 skip --- failure auto_trait_impl_removed: auto trait no longer implemented --- Description: A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented. ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/auto_trait_impl_removed.ron Failed in: type StatisticsContext is no longer Send, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/statistics.rs:175 type StatisticsContext is no longer Sync, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/statistics.rs:175 type StatisticsContext is no longer Send, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/statistics.rs:175 type StatisticsContext is no longer Sync, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/statistics.rs:175 --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_missing.ron Failed in: enum datafusion_physical_plan::aggregates::order::GroupClusteringMode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/aggregates/order/mod.rs:48 enum datafusion_physical_plan::aggregates::GroupClusteringMode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/aggregates/order/mod.rs:48 enum datafusion_physical_plan::aggregates::order::GroupClustering, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/aggregates/order/mod.rs:66 enum datafusion_physical_plan::joins::utils::ProbeOffset, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/joins/join_hash_map.rs:43 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron Failed in: function datafusion_physical_plan::proto::registry::register_execution_plan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/proto/registry.rs:150 function datafusion_physical_plan::proto::register_execution_plan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/proto/registry.rs:150 function datafusion_physical_plan::proto::registry::execution_plan_names, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/proto/registry.rs:189 function datafusion_physical_plan::proto::execution_plan_names, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/proto/registry.rs:189 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: HashJoinExecBuilder::with_null_aware_value_keys, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/joins/hash_join/exec.rs:602 AggregateExec::group_clustering_mode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/aggregates/mod.rs:1916 ExecutionPlanEncodeCtx::extension_node, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/proto/mod.rs:237 PartitionedTopKExec::with_ranking_field, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/sorts/partitioned_topk.rs:284 PartitionedTopKExec::ranking_field, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/sorts/partitioned_topk.rs:326 ExecutionPlanDecodeCtx::decode_children, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/proto/mod.rs:327 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/module_missing.ron Failed in: mod datafusion_physical_plan::proto::registry, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/proto/registry.rs:18 mod datafusion_physical_plan::materialized_cte, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/materialized_cte.rs:18 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_missing.ron Failed in: struct datafusion_physical_plan::materialized_cte::MaterializedCteScanExec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/materialized_cte.rs:662 struct datafusion_physical_plan::aggregates::order::GroupClusteringFull, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/aggregates/order/full.rs:57 struct datafusion_physical_plan::materialized_cte::MaterializedCteBuffer, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/materialized_cte.rs:264 struct datafusion_physical_plan::aggregates::order::GroupClusteringPartial, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/aggregates/order/partial.rs:64 struct datafusion_physical_plan::TopKDynamicFilters, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/topk/mod.rs:187 struct datafusion_physical_plan::materialized_cte::MaterializedCteExec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/materialized_cte.rs:490 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_pub_field_missing.ron Failed in: field null_aware_value_keys of struct HashJoinExec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/joins/hash_join/exec.rs:1043 --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_missing.ron Failed in: trait datafusion_physical_plan::proto::registry::ExtensionPlanFromProto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/proto/registry.rs:79 trait datafusion_physical_plan::proto::ExtensionPlanFromProto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/physical-plan/src/proto/registry.rs:79 Summary semver requires new major version: 8 major and 0 minor checks failed Finished [ 76.704s] datafusion-physical-plan Building datafusion-sqllogictest v55.1.0 (current) Built [ 93.698s] (current) Parsing datafusion-sqllogictest v55.1.0 (current) Parsed [ 0.015s] (current) Building datafusion-sqllogictest v55.1.0 (baseline) Built [ 94.512s] (baseline) Parsing datafusion-sqllogictest v55.1.0 (baseline) Parsed [ 0.017s] (baseline) Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.108s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: DataFusionSubstraitRoundTrip::with_optimization, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/38eb0a41d45e5c318d7ffe633a958e508f768ffa/datafusion/sqllogictest/src/engines/datafusion_substrait_roundtrip_engine/runner.rs:60 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 190.917s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
