alamb commented on PR #25688: URL: https://github.com/apache/datafusion/pull/25688#issuecomment-6225378698
> Thanks @2010YOUY01 for prototyping this! The `InputRequirementsSatisfied` region starts exactly where #25688 draws the analyzer/optimizer boundary, so the two look complementary to me. > > One concern from a downstream pipeline: our internal engine(Atlas) rebuilds the list from `physical_optimizers()`, inserts rules by anchor, and calls `with_physical_optimizer_rules`, which silently drops all regions. An API to insert rules next to a named rule while keeping the markers would help extensions actually get these checks. I agree -- thank you @2010YOUY01 I also have some concerns that I wrote about in https://github.com/apache/datafusion/pull/26360#pullrequestreview-5554104569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
