dwsmith1983 commented on issue #26235: URL: https://github.com/apache/datafusion/issues/26235#issuecomment-6220915590
Adding context from the discussion on #26228 so it's here when someone picks this up. @2010YOUY01 [pointed out](https://github.com/apache/datafusion/pull/26228#issuecomment-6207937548) that declaring the build-side order would constrain a future spilling hash join. If the planner drops a sort (say under a TopK on a build-side column) because the join reports order, a join that later spills can't keep that order, and falling back would mean changing the plan around it. @jayzhan211 [suggested](https://github.com/apache/datafusion/pull/26228#issuecomment-6215375407) gating the guarantee on a config, for example whether spilling is enabled. It's probably worth agreeing on one of those before implementing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
