AdiXgit commented on issue #17498: URL: https://github.com/apache/datafusion/issues/17498#issuecomment-6209204775
Hi, I’d like to take the datafusion.sql_parser.default_null_ordering slice of this issue. On main it’s still a plain string, so SET datafusion.sql_parser.default_null_ordering = nulls_mx succeeds and the value silently falls back to nulls_max when planning ORDER BY. I’ll follow the shape of the merged slices (e.g. #24545, #24642): a typed NullOrdering enum in datafusion-common, validated at SET time, with the previous value kept if a SET is rejected, plus unit tests and set_variable.slt coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
