andygrove commented on PR #4798: URL: https://github.com/apache/datafusion-comet/pull/4798#issuecomment-6203464379
> Thanks, everything from my review is addressed. Building the ungrouped path on the grouped accumulator and switching to `expect_native(pivotfirst)` both make this easier to trust. I'll approve once the `run-spark-4.1-tests` and `run-all-spark-profiles` runs come back green. Thanks @viirya. These were green on the last run. I am going to push another commit to fix conflicts now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
