shazilkhan commented on issue #26303:
URL: https://github.com/apache/datafusion/issues/26303#issuecomment-6183330393
I'll pick this up. Diffed lpad_impl against rpad_impl and yeah, the only
real difference is rpad does write_str(string) before the fill and then
append_value(""), while lpad writes the fill and then append_value(string). So
a const generic for the side should cover it without touching the hot loop.
I'll fold the no-fill branch into the fill path with " " and pull the
i32::MAX / negative length check into a small helper, keeping the error message
the same.
Getting a baseline from the pad benches on main now, will put before/after
numbers in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
