HairstonE commented on PR #26211: URL: https://github.com/apache/datafusion/pull/26211#issuecomment-6175723247
Hi @jdymitarai, thank you for your contribution. The code looks good to me. I traced the changes by hand, and ran a review with Claude. The test you added explicitly tests for this regression, and the test passes with your changes and fails without them. One thing needs to change before I approve. The PR description needs to follow the [DataFusion PR template](https://datafusion.apache.org/contributor-guide/pr_review.html#review-the-pr-description) and answer all the questions in it. Once the description is sorted, I'll hit approve! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
