milenkovicm commented on code in PR #2588:
URL:
https://github.com/apache/datafusion-ballista/pull/2588#discussion_r4273675471
##########
ballista/core/src/serde/mod.rs:
##########
@@ -359,12 +360,26 @@ impl LogicalExtensionCodec for
BallistaLogicalExtensionCodec {
#[derive(Debug)]
pub struct BallistaPhysicalExtensionCodec {
default_codec: Arc<dyn PhysicalExtensionCodec>,
+ /// Codec used for logical plans embedded in physical plan nodes
+ /// (e.g. [DistributedQueryExec])
+ logical_codec: Arc<dyn LogicalExtensionCodec>,
}
impl Default for BallistaPhysicalExtensionCodec {
fn default() -> Self {
Self {
default_codec: Arc::new(DefaultPhysicalExtensionCodec {}),
+ logical_codec: Arc::new(BallistaLogicalExtensionCodec::default()),
Review Comment:
logical codec is not required ballista, I would suggest to create new
`PyBallistaPhysicalExtensionCodec` and have it there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
